search

lumigo-io / lambda-telemetry-shipper

Ship your AWS lambda telemetry anywhere. The no-code style.
Apache License 2.0
6 stars 1 forks source link

feat: ability to disable the S3 logging prefix #5

Closed CynanX closed 1 year ago

CynanX commented 1 year ago

A lambda may be outputting JSON to be ingested by another service, such as QuickSight. This extension currently prefixes the lambdas output with a timestampe and the record type.

This change allows the prefix to be disbaled by setting LUMIGO_EXTENSION_DISABLE_LOG_PREFIX to True.

CynanX commented 1 year ago

All comments should have been address now - thank you!

CynanX commented 1 year ago

Quick question. When will this get deployed, and will that end in a :2 version (will need to update the README)? Thank you!

saartochner-lumigo commented 1 year ago

Hi, We will release another version soon. In the meanwhile, a best practice is to create your own extension: simply execute ./scripts/deploy.sh.

Saar

CynanX commented 1 year ago

Hi, We will release another version soon. In the meanwhile, a best practice is to create your own extension: simply execute ./scripts/deploy.sh.

Saar

Thank you.

P.S. using your script doesn't work for me.

gpg: can't open '../common-resources/encrypted_files/credentials_production.enc': No such file or directory
CynanX commented 1 year ago

I can see the deploy script has since been updated, reran that which got further, and restricted it to deploy to eu-west-1 only:

Extension layer
-Installing the package and its dependencies
- Use default credentials
-create directories to zip
--extension
mkdir: extensions: File exists
--shipper
mkdir: extension-python-modules: File exists
--python runtime
download: s3://lumigo-runtimes/python/python-runtime-38.zip to ./runtime.zip
replace python/runtime/bootstrap.py? [y]es, [n]o, [A]ll, [N]one, [r]ename: y
replace python/runtime/urllib3-1.25.10.dist-info/RECORD? [y]es, [n]o, [A]ll, [N]one, [r]ename: A
mv: rename python to python-runtime/python: Directory not empty
-zipping
-publish

SSL validation failed for https://lambda.eu-west-1.amazonaws.com/2018-10-31/layers/lumigo-telemetry-shipper/versions EOF occurred in violation of protocol (_ssl.c:2423)

usage: aws [options] <command> <subcommand> [<subcommand> ...] [parameters]
To see help text, you can run:

  aws help
  aws <command> help
  aws <command> <subcommand> help

aws: error: argument --version-number: expected one argument

published layer version:  in region: eu-west-1

Done! Latest version:
saartochner-lumigo commented 1 year ago

Yes, I have simplified the script to make similar requests easier to handle in the future :)

It seems that the command aws lambda publish-layer-version has failed due to EOF occurred in violation of protocol. Maybe you can find the root cause in one of the following? https://github.com/aws/aws-cli/issues/3268 https://stackoverflow.com/questions/32946050/ssl-certificate-verify-failed-in-aws-cli

Please LMK if there's anything else that I can help with