lumigo-io / lumigo-CLI

Open source CLI tool to help you develop and manage serverless applications.
https://lumigo.io
Apache License 2.0
331 stars 21 forks source link

Can you please change "press any key to end" to "press ctrl-c"? #122

Open gswallow opened 3 years ago

gswallow commented 3 years ago

Amazing tool but I keep killing it inadvertently. :)

efimk-lu commented 3 years ago

Hey @gswallow, which command are we talking about?

gswallow commented 3 years ago

I'm using the eventbridge one, so it's somewhere in https://github.com/lumigo-io/lumigo-CLI/blob/aa2cb8c2a530268aa18739d7d3dcadda7e9ca001/src/commands/tail-eventbridge-rule.js#L143-L154

I took a crack at it but gave up since my grasp of NodeJS is pretty much zero. If you're going to change one command, you may as well change them all. :)

On Sun, May 9, 2021 at 11:03 AM Efi Merdler-Kravitz < @.***> wrote:

Hey @gswallow https://github.com/gswallow, which command are we talking about?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lumigo-io/lumigo-CLI/issues/122#issuecomment-835823966, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAHXKH24EFU2IVLW23K2ZTTM2P2RANCNFSM44PGB6CA .

LeoLapworthKT commented 2 years ago

I have the same issue --- even just allowing return so I can put in a bit of space between events would be nice

gswallow commented 2 years ago

ehhhh I took another crack at it. https://github.com/lumigo-io/lumigo-CLI/pull/125