lumigo-io / lumigo-node

Lumigo's Node.js Distributed Tracing and Performance Agent
https://lumigo.io
Apache License 2.0
76 stars 12 forks source link

RD-10988-extend-secret-scrubbing-and-automatic-tag-extraction-in-the-lambda-node-js-tracer-to-be-able-to-handle-nested-stringified-json #457

Closed shanishiri closed 1 year ago

saartochner-lumigo commented 1 year ago

Hi, why not on node-core? https://github.com/lumigo-io/node-core/blob/master/src/common/secrets.ts Also, I would suggest that you do it behind an env var. This could be a significant performance issue.

codecov[bot] commented 1 year ago

Codecov Report

Merging #457 (f529b07) into master (4e438b5) will decrease coverage by 0.21%. Report is 467 commits behind head on master. The diff coverage is 99.75%.

@@             Coverage Diff             @@
##            master     #457      +/-   ##
===========================================
- Coverage   100.00%   99.79%   -0.21%     
===========================================
  Files           19       39      +20     
  Lines         1165     2388    +1223     
  Branches       246      664     +418     
===========================================
+ Hits          1165     2383    +1218     
- Misses           0        4       +4     
- Partials         0        1       +1     
Files Changed Coverage Δ
src/utils/payloadStringify.js 100.00% <ø> (ø)
src/utils/requireUtils.js 100.00% <ø> (ø)
src/utils/utf8Utils.ts 100.00% <ø> (ø)
src/utils/w3cUtils.ts 100.00% <ø> (ø)
src/hooks/mongodb4x.ts 96.61% <96.61%> (ø)
src/globals.ts 99.27% <99.27%> (ø)
src/utils.ts 99.42% <99.42%> (ø)
src/events/events.ts 100.00% <100.00%> (ø)
src/events/trigger-parsers/step-function-parser.ts 100.00% <100.00%> (ø)
src/events/trigger-parsers/trigger-parser-base.ts 100.00% <100.00%> (ø)
... and 29 more
doriaviram commented 1 year ago

:tada: This PR is included in version 1.85.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: