search

lumina-desktop / lumina

Lumina Desktop Environment
http://lumina-desktop.org
BSD 3-Clause "New" or "Revised" License
532 stars 116 forks source link

Panel not showing all icons #649

Closed q-pa closed 5 years ago

q-pa commented 5 years ago

Fresh install of 18.12-RELEASE. The Thunderbird icon is missing from the panel (only showing some default icon). In the settings menu it shows correctly, though. See attached two screenshots. screenshot-panel

screenshot-panel-settings

beanpole135 commented 5 years ago

I just fixed this a moment ago: https://github.com/lumina-desktop/lumina/commit/9ca1d49ef773adae2a26758a61c9db3b029d93b1

q-pa commented 5 years ago

screenshot-panel2 Update U2 did not resolve this issue. Now, the icon does show the Gnome footprint, though...? Could you please re-open this issue? Thanks!

beanpole135 commented 5 years ago

Reopening for review again.

q-pa commented 5 years ago

On my old TrueOS installation where the panel is showing a thunderbird icon, the only icon I could find is located in the directory: /usr/local/share/icons/pixmaps/apps

q-pa commented 5 years ago

FYI, I created this directory and copied the .png file plus I copied two different icon sizes to the hicolor directory... still not working.

q-pa commented 5 years ago

Since today's update U6 the icon for AppCafé is another default icon.

beanpole135 commented 5 years ago

ok, now this is fixed with commit https://github.com/lumina-desktop/lumina/commit/5747f7fe96c2419f8837bafd7122ba2a1ad04497

It was a combination of two issues:

  1. The thunderbird XDG shortcut was partially-invalid because it was specifying the file extension (which you are not supposed to do with icons from the global theme). I added a detection/skip of any file extension on a theme icon and that works much better now.
  2. The new LFileInfo class that the quicklaunch widgets uses did not have the backwards compatibility for the old pixmaps directory - which was preventing the appcafe icon from getting loaded on those buttons. I enhanced that class to support that old dir again, as well as added the initial file->icon conversion routine within that class itself (since that class is where Lumina is trying to put the handling for all the special kinds of files to make it easier to use across all sorts of different projects).
q-pa commented 5 years ago

Updated to U7, Thunderbird icon is showing now but still no AppCafé icon...

utrenkner commented 5 years ago

I confirm, this problem persists in 1.5.0. I just upgraded from the current FreeBSD port (1.4.1), yesterday, and several app icons in the panel have been replaced with a default file icon.

Screenshot-2019-05-28-14-41-31

In the settings they are still there: Screenshot-2019-05-28-14-43-12

Lumina was built from the 1.5.0 release sources on FreeBSD 12.0-RELEASE-p4.

q-pa commented 5 years ago

I am on Trident-1905 with Lumina 1.5.0 and still missing the AppCafé icon.