Closed CHAOS-en-Krojerk closed 2 years ago
Can you try by including #include LuminaX11.cpp
?
What is your version of Qt?
Qt version 5.7.1. Tried to add #include
Qt version is too old. https://doc.qt.io/qt-5/qimage.html#sizeInBytes
After https://github.com/lumina-desktop/lumina/pull/706 minimal Qt version should be 5.11...
cc @beanpole135
After some review, it appears that the QImage size function change is fairly important to Qt, as there are some significant warnings about file sizes and such on the depricated function, so I am leaning toward just documenting the new minimum Qt version for the master branch of the Lumina desktop sources. By the same token, it appears that the new size functions were added in Qt 5.10, unless @lbartoletti is aware of some other functions aside from the QImage::sizeInBytes() we are now using which require Qt 5.11
Im closing this as it seems that a newer qt version was the solution, and the documentation has been udpated.
When I'm trying to compile using make/make install, it gives me the following compilation errors:
../libLumina/LuminaX11.cpp: In member function ‘QIcon LXCB::WindowIcon(WId)’: ../libLumina/LuminaX11.cpp:501:6: error: ‘qsizetype’ was not declared in this scope for(qsizetype i=0; i<image.sizeInBytes()/4; ++i, ++dat){ ^
~~~~ ../libLumina/LuminaX11.cpp:501:21: error: ‘i’ was not declared in this scope for(qsizetype i=0; i<image.sizeInBytes()/4; ++i, ++dat){ ^ ../libLumina/LuminaX11.cpp:501:29: error: ‘class QImage’ has no member named ‘sizeInBytes’ for(qsizetype i=0; i<image.sizeInBytes()/4; ++i, ++dat){ ^~~../libLumina/LuminaX11.cpp: In member function ‘void LXCB::paintRoot(QRect, const QPixmap*)’: ../libLumina/LuminaX11.cpp:550:12: error: ‘class QImage’ has no member named ‘sizeInBytes’ 0, qimage.sizeInBytes(), qimage.bits()); ^~~Makefile:1283: recipe for target '.build/obj/LuminaX11.o' failed make[3]: [.build/obj/LuminaX11.o] Error 1 make[3]: Leaving directory '/root/lumina/src-qt5/core/lumina-desktop' Makefile:47: recipe for target 'sub-lumina-desktop-make_first' failed make[2]: [sub-lumina-desktop-make_first] Error 2 make[2]: Leaving directory '/root/lumina/src-qt5/core' Makefile:44: recipe for target 'sub-core-make_first' failed make[1]: [sub-core-make_first] Error 2 make[1]: Leaving directory '/root/lumina/src-qt5' Makefile:42: recipe for target 'sub-src-qt5-make_first' failed make: [sub-src-qt5-make_first] Error 2What I did before: