search

luminoso / fedora-copr-signal-desktop

https://copr.fedorainfracloud.org/coprs/luminoso/Signal-Desktop/
19 stars 5 forks source link

Remove GConf dependency #15

Closed aklapper closed 2 years ago

aklapper commented 2 years ago

Following https://copr.fedorainfracloud.org/coprs/luminoso/Signal-Desktop/ , after sudo dnf copr enable luminoso/Signal-Desktop and sudo dnf install signal-desktop, dnf wants to install GConf2 which is an ancient unmaintained GNOME backend. https://github.com/signalapp/Signal-Desktop/issues/2344 implies that this should not be needed.

luminoso commented 2 years ago

Thank you for the heads up! Will do a rebuild without it and ping here once done

luminoso commented 2 years ago

Bump. Removed GConf dependency.

Update via: sudo dnf --refresh upgrade signal-desktop

aklapper commented 2 years ago

Confirming for 5.29.1-3.fc35, thanks a lot for the quick fix!

aklapper commented 2 years ago

(I'm also still a bit surprised to see packages like libappindicator-gtk3, libdbusmenu, libdbusmenu-gtk3, libindicator-gtk3 listed as dependencies to be installed. Are you sure those are really required?)

luminoso commented 2 years ago

I just mimic the debian dependencies to Fedora when I created the package. And you're right. I never made a review if they're still up to date.

What is listed as dependency is: libnotify, libappindicator-gtk3, libXtst, nss, libXScrnSaver

and their upstream requirements list is: https://github.com/signalapp/Signal-Desktop/blob/ec04e520ecfdae7360dfb36faafa2c01878a9cc2/package.json#L386

maybe libXScrnSaver and libappindicator-gtk3 are already deprecated too. I'll experiment removing them on the next build

luminoso commented 2 years ago

Done. Pushed 5.30.0-1 where libXScrnSaver and libappindicator-gtk3 are removed. please report any issues