search

luminous-software / start-page-plus-64-bit

64-bit version of the original Start Page+ (for VS 2022+)
MIT License
5 stars 1 forks source link

adds option to disable developers news on start page (fixes #2 ) #32

Closed MagicAndre1981 closed 1 year ago

MagicAndre1981 commented 1 year ago

allowing users to turn off developers news ( fixes #2 )

yannduran commented 1 year ago

There are a couple of changes that need to be made, but you haven't enabled me to make any changes to the pull request.

MagicAndre1981 commented 1 year ago

but you haven't enabled me to make any changes to the pull request.

I did:

image

image

MagicAndre1981 commented 1 year ago

if you still can't commit, close it and do it on your own. I only tried to show that is very easy

yannduran commented 1 year ago

OK, I'll do that. I'll try to make the changes again. You did solve one of the problems that I have a vague memory of.

If not I'll do as you suggest and do it myself. I just didn't want to not accept a generously offered pull request.

Thanks André!

yannduran commented 1 year ago

I can provide you with the experience that you've been able to achieve yourself so far, of course. But the main problem that remains is replacing the UniformDock control with something that will still give users who do want all 3 panes the same experience as now. Mainly for if they change the MaximumWidth property, or move from one monitor to another that uses a different ratio etc.

I have a few ideas I want to try, but that'll probably be sprint v0.23, or sooner if I'm able to get through things quicker.

yannduran commented 1 year ago

Being a one-man shop developer, I've never needed to use pull requests. It's always just been me How do I add code. Do I have to clone the public repo and do it in the pull request there, then push it back up for you to do whatever you need to do and then I approve it?

Is that how it works? I don't mind learning about pull requests though.

yannduran commented 1 year ago

Add more commits by pushing to the issue2disabledevelopernews branch on MagicAndre1981/start-page-plus-64-bit.

Ahh, there was a line there telling me what to do lol

yannduran commented 1 year ago

Added in v0.22