search

luminous-software / start-page-plus

Bring back Start Page! (a document tab, NOT a modal window)
MIT License
19 stars 9 forks source link

Hide StartPage+ on solution load, restore on solution close #63

Open stimpy77 opened 5 years ago

stimpy77 commented 5 years ago

Installed product versions

Description

I don't need the StartPage+ window at all if I've loaded up a project. So I close it. But then I end up seeing a blank screen if I close the solution or if I close Visual Studio and launch it again. So I have to start StartPage+ again. And then when I load up a solution I don't need it anymore so I have to close StartPage+ again. This back-and-forth manual effort is a nuisance.

Please add the option in the configuration screen to close StartPage+ on solution open and restore StartPage+ on solution close, and consider defaulting this behavior to enabled. This is the same behavior as in VS 2017's built-in Start Page, and was a good behavioral design.

Steps to recreate

  1. Start StartPage+
  2. Open a solution
  3. StartPage+ is still visible. Close it.
  4. Close the solution. Now the environment is empty and StartPage+ isn't visible.

Current behavior

StartPage+ is always visible until manually closed, and always closed until manually launched.

Expected behavior

StartPage+ should optionally auto-close when a solution opens and auto-launch when no solutions are open.

yannduran commented 5 years ago

Hi Jon! These two features were always going to be implemented, I just have to prioritise what I do, and I figured that people having to manually open and close the windows wouldn't be as bad as other features not getting done.

I love that you have ideas on features to suggest, but could I ask you do do something for me? Before adding a new issue, could you check the open issues first? I had already added this feature a while ago in luminous-software/start-page-plus#18 from feedback from another user.

You could also check luminous-software/start-page-plus#1, where I tried to capture ideas, comments etc from forum posts all in one place, so people could see what I'm aware of, or what I have planned. Even though I subsequently started creating issues as I thought of things, it still has a lot of information in it.

I'm going to close luminous-software/start-page-plus#18 and keep this one open instead, because yours is has more details. I created luminous-software/start-page-plus#18 on behalf of another user and it was just a quick way to capture the feature so that people could see that I had it planned.

Thanks again for the feature suggestion!

stimpy77 commented 5 years ago

Yann, "Before adding a new issue, could you check the open issues first?" is highly offensive to me as it presumes that no effort was made to check open issues before creating the ticket, which I did, I did not see the individual detail in luminous-software/start-page-plus#1. Broad, sweeping "post it all" posts are not the appropriate place on GitHub for tracking issues. Also, I implemented the exact feature in my own extension which brought back the VS2017 start page until Microsoft removed the base functionality completely, so you could have simply asked me to fork and create a pull request rather than try to tell me how to use GitHub.

yannduran commented 5 years ago

Oh Jon, I'm so sorry, I definitely didn't mean any offense, or to talk down to you in any way. In fact I specifically tried very hard to ask as gently as I could. You never know what the other person's experience level is, so all I had to go on was what had occurred.

The ONLY reason I mentioned it at all was because the feature had already been captured in in existing issue, and yet a new issue had been opened for the same thing. What other conclusion should I be expected to have come to, other than the open issues hadn't been checked? I was actually trying to be helpful. Can I ask a question? And I'm not trying to be smart, or offend you again, I'm genuinely interested. If you checked the open issues, why did you add a new issue for the same feature?

I also didn't mean that you should have read issue luminous-software/start-page-plus#1 before adding your issue (although I see that I worded it badly), I was only pointing out that there was more information that you might be interested in, that had been captured before I had a chance to expand it into issues.

By informing me that "Broad, sweeping 'post it all' posts are not the appropriate place on GitHub for tracking issues" I could choose to be offended, but I'm actually not offended, because hopefully that wasn't your intention. It's so easy to misinterpret another person's intentions from just written words.

And I would welcome any pull requests you care to submit. I see you've forked the repo already, so I look forward to any code that you'd care to contribute. Obviously I can't do everything myself unless I prioritise what I do first, so help is welcome.

I'm re-opening this issue because a) I meant what I said before about this issue being better than my quick placeholder one, and b) because this feature suggestion is something that needs be visible so its progress can be tracked.

I really hope that I've managed to clear the air between us over this misunderstanding.

yannduran commented 4 years ago

@stimpy77

I didn't manage to get this into v1.0, but it'll definitely be in v1.2 or v1.3.

MagicAndre1981 commented 1 year ago

@stimpy77 can you please create the PR again for the VS2022 version?