luminousleek / pe

0 stars 0 forks source link

Inconsistent behaviour when filtering by different fields #6

Open luminousleek opened 2 years ago

luminousleek commented 2 years ago

Bug: Trying to filter with a non-existent faculty gives a "Faculty not found" error, but trying to filter with a non-existent skill/language/framework/tag gives 0 people in the filtered list

Steps to reproduce: filter f/asdf, and then filter fr/asdf

Filtering wrong faculty:

Screenshot 2021-11-12 at 4.42.00 PM.png

Filtering wrong framework:

Before filter:

Screenshot 2021-11-12 at 4.44.14 PM.png

After filter:

Screenshot 2021-11-12 at 4.44.24 PM.png

nus-pe-bot commented 2 years ago

Team's Response

Thank you for this bug report. But we would like to let you know that this is the expected response. As faculty for NUS students is predefined in the app whereas skills/frameworks/languages/tags are user defined Therefore the app does not recognise an incorrect faculty but will show output for non-existing skills/frameworks/languages/tags

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

[x] I disagree

Reason for disagreement: The bug is that these two cases are handled differently, which is not expected by the user. It should not matter if this is how the features were designed, because the end result is still an inconsistent handling of invalid inputs.