search

luminus-framework / lein-cprop

Leiningen plugin for generating cprop configuration for Luminus
4 stars 0 forks source link

Hooks deprecation #1

Open dijonkitchen opened 5 years ago

dijonkitchen commented 5 years ago 
Warning: implicit hook found: lein-cprop.plugin/hooks 
Hooks are deprecated and will be removed in a future version.

https://github.com/technomancy/leiningen/blob/master/doc/PLUGINS.md#hooks

Other relevant information: https://github.com/technomancy/leiningen/issues/2387

yogthos commented 5 years ago

Any chance you would be up for doing a pr to remove the hook?

dijonkitchen commented 5 years ago

Sorry, I don't know how to do this right now, but wanted to note it for anyone else trying to figure it out.

yogthos commented 5 years ago

As a note, the plugin is no longer used in Luminus because config is read from an external file such as dev-config.edn. So, while it would be good to fix it, the usage pattern is deprecated.