search

luminus-framework / luminus-template

a template project for the Luminus framework
http://www.luminusweb.net/
MIT License
648 stars 146 forks source link

Reload on another page ends up on home, disabling menu link #143

Closed ulsa closed 9 years ago

ulsa commented 9 years ago

Tried this on Chrome, Firefox and Safari.

  1. Created a new project from template 2.9.8:

    % lein new luminus lumitest +cljs
% cd lumitest
% lein run

% lein figwheel
  2. Clicked on About link in menu, and correctly ended up on About page.
  3. Reloaded browser when on http://localhost:3000/#/about. Now the problems start.
  4. After reload finished, ended up on Home page, not About page.
  5. Clicking About in menu does nothing.

Created a new Reagent project using lein new reagent, and added basic Bootstrap navbar support. It didn't have this problem.

yogthos commented 9 years ago

Ah thanks for noticing, there was an extraneous (session/put! :page :home) call in the init! function in the ClojureScript namespace. I've removed it and pushed out a new version with the fix.

ulsa commented 9 years ago

Removed that line from init! and it works. Also tested the new template, works fine. Thanks!

yogthos commented 9 years ago

great to hear