search

luminus-framework / luminus-template

a template project for the Luminus framework
http://www.luminusweb.net/
MIT License
645 stars 147 forks source link

+shadow-cljs includes package.json in gitignore #536

Closed tkindy closed 3 years ago

tkindy commented 3 years ago

Hi! I'm new to Luminus and ClojureScript in general, so let me know if I don't have things quite right here.

In 3.78, the template stopped including :npm-deps shadow-cljs deps in the project.clj file. In 4.10, the template started including a package.json directly. However, the package.json file is still included in the .gitignore for projects that add shadow-cljs.

Is that meant to be the case? It seems like it might just be an oversight, but I'm just getting started with shadow-cljs so I don't know for sure.

Thanks!

yogthos commented 3 years ago

Hi,

Thanks for the heads up. The recent change was to switch to using shadow-cljs directly and package.json being part of .gitignore is indeed an omission on my part. Both package.json and shadow-cljs.edn files should now be part of the repository. I've just pushed out a fix for the template as well. Let me know if everything looks good.

tkindy commented 3 years ago

I just created a project with the new version of the template and confirmed both package.json and shadow-cljs.edn are appropriately included when using git. Thanks for the quick fix!