search

luminus-framework / luminus-template

a template project for the Luminus framework
http://www.luminusweb.net/
MIT License
647 stars 147 forks source link

Update Calva config to change away from lein-shadow #540

Closed PEZ closed 3 years ago

PEZ commented 3 years ago

I've updated the Client + Server jack-in configuration to plain shadow-cljs.

I also changed the shadow-cljs config to include the Leiningen project's dev profile. I've checked that this does not impact the release build of the client app with Thomas Heller, who gave me this to read: https://code.thheller.com/blog/shadow-cljs/2018/02/08/problem-solved-source-paths.html Let me know if you want this in a separate PR, or not at all.

I don't know why the PR got a bit messy. Can you take it like this, or should I clean it up?

yogthos commented 3 years ago

The change looks ok, but I think the PR got merged with an older clean up for shadow-cljs. Might be easier to do a new one against the latest in master. And I think shadow dev profile update would be fine in the same pr, thanks for taking a look. :)

PEZ commented 3 years ago

Filed a new, cleaner, PR =)