luminus-framework / luminus-template

a template project for the Luminus framework
http://www.luminusweb.net/
MIT License
645 stars 147 forks source link

Triple quote in generated html template. #567

Closed bobyuancn closed 1 year ago

bobyuancn commented 1 year ago

In your document: https://luminusweb.com/docs/assets.html It is written:

{% style "/assets/bulma/css/bulma.min.css" %}
{% style "/assets/material-icons/css/material-icons.min.css" %}

But in generated webapp, it will having (""" in beginning for /assets/) in base.html and error.html:

    <!-- styles -->
    {% style """/assets/bulma/css/bulma.min.css" %}
    {% style """/assets/material-icons/css/material-icons.min.css" %}

This will not cause a problem when running, but the triple quote (""") is not the same with your documentation, and will cause confusion.

yogthos commented 1 year ago

Thanks for the report, looks like it was a typo in the HTML template where extra quotes were introduced. Just pushed out a release with a fix.