luminus-framework / luminus-template

a template project for the Luminus framework
http://www.luminusweb.net/
MIT License
645 stars 147 forks source link

`lein new luminus +async` command generate problem #576

Closed corkine closed 9 months ago

corkine commented 1 year ago

After the project 'lein new luminus hello+http-kit+postgres+swagger+cljs+agent+re-frame+shadow-cljs+async' is generated as follows, both dev-config.edn and core.clj are correct async?, However, test-config.edn contains the async field without a question mark. Is this a bug?

dev-config.edn

{:dev true
 :port 3000
 ;; when :nrepl-port is set the application starts the nREPL server on load
 :nrepl-port 7000
 :async? true

 ; set your dev database connection URL here
 ; :database-url "postgresql://localhost/hello_dev?user=db_user_name_here&password=db_user_password_here"
}

test-config.edn

{:port 3000
 :async true
 ; set your test database connection URL here
 ; :database-url "postgresql://localhost/hello_test?user=db_user_name_here&password=db_user_password_here"
}
yogthos commented 1 year ago

Yeah, looks like I missed a condition there. Would be a matter of updating the template for the test config to check for async there.

yogthos commented 9 months ago

fixed in the latest release