search

luminus-framework / luminus

documentation site for Luminus framework
http://www.luminusweb.net/
629 stars 121 forks source link

Websockets page does not contain an example for the new default server Jetty #245

Closed sorsasampo closed 5 years ago

sorsasampo commented 5 years ago

The Websockets page contains websocket examples for Immutant and HTTP KIT, but not for the new default server Jetty (since luminus-template 3.37).

http://www.luminusweb.net/docs/websockets.html

yogthos commented 5 years ago

The official Jetty adapter doesn't appear to provide Websocket support, I'd recommend using HTTP Kit if you need Websockets. It might make sense to switch Luminus to use it as the default.

sorsasampo commented 5 years ago

I think websocket support is kind of important nowadays, so I would personally find it sensible to default to a server that supports them. I'm closing this issue as there is no way to provide an example for an implementation that does not exist!

yogthos commented 5 years ago

I agree that ws support is important, and I'll investigate what might be the best option going forward. I'm leaning towards Aleph as the default, but it has a couple of issues that I'd like to see addressed first.