search

luminus-framework / ring-undertow-adapter

Ring Undertow adapter
MIT License
44 stars 12 forks source link

Ring websocket API support #29

Open weavejester opened 11 months ago

weavejester commented 11 months ago

I've been working on a Ring websocket API that's currently in experimental alpha. Would you be interested in a PR to support this in Luminus to be merged when the Ring websocket API is stable?

The reason I'm asking this while the Ring API is still experimental is that I'd like to try implementing the API for different third-party adapters, so I can get feedback and forewarning of any design issues. I've submitted a similar issue to the ring-jetty9-adapter project, and another one to http-kit.

yogthos commented 11 months ago

Oh yeah, a PR would be very welcome, I think experimental status is fine. We can add a note regarding that in the readme.