lumoslabs / txgh

A library for automatically syncing translation resources between Github and Transifex.
1 stars 1 forks source link

Use tip of branch instead of commit sha when updating Transifex resources #36

Closed camertron closed 8 years ago

camertron commented 8 years ago

Currently we're using the SHAs from the webhook payload body to update Transifex resources. This means that webhook requests triggered by pushes to the same branch may actually get processed in the wrong order, i.e. more recent content may get overwritten by older content. This should work in all cases, even when txgh isn't configured to upload resources by branch. In the world of git, you're always pushing to some branch, even if that branch is just master. In other words, commits are inherently chronological.

@lumoslabs/platform

niwen commented 8 years ago

👍