search

lumoslabs / txgh

A library for automatically syncing translation resources between Github and Transifex.
1 stars 1 forks source link

Publish event after receiving Transifex webhook #72

Closed camertron closed 6 years ago

camertron commented 6 years ago

PLAT-1662

This should enable us to notify CS/CX when translations are complete for certain projects.

@lumoslabs/platform

camertron commented 6 years ago

@agirdler-lumoslabs yes, it does publish an event every time the webhook is fired. Fortunately the Transifex webhooks fire relatively infrequently.

Check out the description in the ticket. Basically CS/CX wants to receive a Slack message whenever content in the Zendesk project is finished being translated. The event I added (which by the way is a txgh-specific event and not at all related to our analytics event system) will be handled in another project and only take action for the Zendesk project, further limiting the impact.

agirdler-lumoslabs commented 6 years ago

@camertron yeah I understand all of that. I was just verifying we were going to be processing these further down the line(i.e. not just sending a slack message whenever we get this event) since there isn't any filtering logic in this PR. Curious as to where we do the decision making(lamdba?)

camertron commented 6 years ago

@agirdler-lumoslabs ah ok. Yeah, my plan is to handle the events further down the line. We have another repo where all the deploy configs and such are managed, which sets up event listeners that take Lumos-specific action (like posting to a Slack channel).