search

lumphe / ftp-ts

FTP-ts is an FTP client module for node that provides an asynchronous interface for communicating with a FTP server.
MIT License
9 stars 5 forks source link

ftp-ts doesn't work with node 8 #2

Closed warpdesign closed 2 years ago

warpdesign commented 6 years ago

When trying to use ftp-ts with node 8 on macOS I get the following error:

TypeError: Symbol.asyncIterator is not defined.

Updating to node 10 fixes the problem.

TimLuq commented 6 years ago

Without downleveling the for-await loops Node 8 and low minor versions of 9 will need to be started using either the --harmony_async_iteration or --harmony flag.

@lumphe I am unsure if we want to make a branch in main and load a downleveled version, if for-await is not supported, or if we just want to just add this behavior to the documentation.

warpdesign commented 6 years ago

That's what I thought but didn't bother looking for the flag name.

How about mentioning that into the readme file? Sounds like it would be enough to me.

TimLuq commented 2 years ago

Fixed in v1.1.0/master.