search

lumy / mingus

Automatically exported from code.google.com/p/mingus
GNU General Public License v3.0
0 stars 0 forks source link

Better range matching in from_Hertz #82

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
See the thread on the mailing list started by Gabriel:
http://groups.google.com/group/mingus-python/browse_thread/thread/63904f0fc1d369
a0

The problem:

These are the A's:

440 Hz => A-4
880 Hz => A-5

This is G#-4:

415.305 Hz => G#-4

All of this is correct, but:

439 Hz => G#-4

Where you would probably expect A-4.

  G#-4 -------------- A-4 --------------------
  |                 ^ |                   
  415.305             440.0

Original issue reported on code.google.com by Rhijnauwen@gmail.com on 7 Jul 2009 at 3:43

GoogleCodeExporter commented 9 years ago 
btw, `return self` should also be added as the last line of the method.

Original comment by Rhijnauwen@gmail.com on 7 Jul 2009 at 3:44

GoogleCodeExporter commented 9 years ago 
Another problem is that values below the standard_pitch are wrong. Gabriel 
submitted
a fix for this in a later post.

Original comment by Rhijnauwen@gmail.com on 7 Jul 2009 at 8:33

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r566.

Original comment by Rhijnauwen@gmail.com on 12 Sep 2009 at 7:56