search

lunakurame / firefox-gnome-theme

A theme for Firefox 57+ matching GNOME Adwaita.
The Unlicense
200 stars 15 forks source link

Tab content flexbox improvements #35

Closed rafaelmardojai closed 6 years ago

lunakurame commented 6 years ago

Next time add at least a short description what does your pull request change, it took me a while to find any changes in behavior.

Looks like if you mute a tab, the mute icon teleports next to the label after a random time (~3 seconds), your changes fix that issue, thanks!

lunakurame commented 6 years ago

Do you know what is .tabbrowser-tab[bussy] for? You added it in #16 and now you changed [bussy] to [busy], but not in all places, so we have both. I can't find any tabs with this attribute.

rafaelmardojai commented 6 years ago

That was an error, by mistake I added an extra "s" to "busy".

lunakurame commented 6 years ago

Oh, okay then, I'll change the rest of bussy to busy. But what is this selector for? I can't find any tabs with the busy attribute.

rafaelmardojai commented 6 years ago

The busy attribute is similar to progress. When you load a new tab from a link, that tab usually get the busy attr. Or when you start Firefox, the homepage tab have the busy attr too.

Edit: but this attribute disappears quickly.

lunakurame commented 6 years ago

Okay, makes sense. Thanks for clarifying.