Better support for the menu bar

lunakurame / firefox-gnome-theme

A theme for Firefox 57+ matching GNOME Adwaita.

The Unlicense

200 stars 15 forks source link

Better support for the menu bar #39

Closed YarnSphere closed 6 years ago

YarnSphere commented 6 years ago

Currently this is what happens when the menu bar is shown by pressing alt or ticking the Menu Bar option (in FF 60.0 with CSD enabled): screenshot from 2018-05-14 10-14-58

I'm not saying that it should look perfect since GNOME applications have no menu bar anyway, but perhaps it could look a little less broken? :)

Thank you for your work!

rafaelmardojai commented 6 years ago

Please, test #40 and let me know.

YarnSphere commented 6 years ago

Tested; LGTM! Thank you for your work!

lunakurame commented 6 years ago

Thanks for reporting this bug and thank you @rafaelmardojai for fixing it! I'm surprised you found a way to even add CSD autodetection, are there any known bugs? It looks stable to me, maybe it could even replace all those manual CSD switches completely, or at least land in the new ui/recommended-features.css file when we add it (#36).

rafaelmardojai commented 6 years ago

@kurogetsusai there's no known bugs and is working on Stable, Beta & Nightly.

Maybe we can wait to one more version, and if Mozilla don't break nothing we can default experimental-auto-csd.css and include it to core when #36 is done.