search

lunakurame / firefox-gnome-theme

A theme for Firefox 57+ matching GNOME Adwaita.
The Unlicense
200 stars 15 forks source link

Back button slightly larger than forward button (blurry back icon) #41

Closed YarnSphere closed 6 years ago

YarnSphere commented 6 years ago

This is a minor issue but, as you can see, the back button is slightly larger than the forward one, making the icon appear blurry: screenshot from 2018-05-18 15-11-05

I'm not sure if this only happens to me. My monitor has a 1920:1080 ratio; the issue exists independently of the size of the Firefox window. Using latest master under FF 60.0.

Once again, thank you for your work!

lunakurame commented 6 years ago

Oh god, that bug again. It was already fixed for FF 57, then again for FF 58, then it actually worked without changes for FF 59 and now it's broken again: #17. It's because the back button is bigger in Firefox' default theme to implement that fancy circle around it. Mozilla keeps changing the styles every release, so our overrides stop working and the icon scales improperly. I'll fix it in a second since I already found the culprit. Thanks for reporting it!

YarnSphere commented 6 years ago

My bad for opening a new issue, I should have browsed through the closed ones beforehand! But I'm glad that it's easy to fix! It's one of those small issues that drive you nuts after you notice them for the first time! :D

lunakurame commented 6 years ago

Yeah, small issues you notice, fix, and then they come back a hundred times. :P It's okay tho, the icon or the whole button is usually just forced to scale to some arbitrary size, so unsetting those rules fixes the problem. Just pushed a fix to master, works fine for me now.

YarnSphere commented 6 years ago

Works fine for me too! Thank you for the quick fix!