search

lunakurame / firefox-gnome-theme

A theme for Firefox 57+ matching GNOME Adwaita.
The Unlicense
200 stars 15 forks source link

Doesn't work at all with CSDs on Firefox 65 #53

Closed JaneSmith closed 5 years ago

JaneSmith commented 5 years ago

I'm running Firefox 65.0 on Arch Linux. If I have the Firefox titlebar enabled, then it works fine. However, if I disable the titlebar in order to have the CSD approach, I end up with this:

screenshot from 2019-02-12 20-22-18

As you can see, I have a completely blank headerbar. This happens if I uncomment either the @import "ui/experimental-auto-csd.css"; or @import "ui/csd.css"; line in userChrome.css.

I've also tried the fork by @rafaelmardojai and I have exactly the same issue there.

rafaelmardojai commented 5 years ago

This is a known issue. Firefox reworked its CSD and break this theme.

But nobody is working on this theme now so...

JaneSmith commented 5 years ago

That's really disappointing. I loved this theme back it worked. It made Firefox into a great alternative to GNOME Web.

rafaelmardojai commented 5 years ago

I decided to take this project again. Please test last changes on repo.

Currently looks like this for me: captura de pantalla de 2019-02-16 21-52-27

Saroufim commented 5 years ago

I can't seem to apply the updates. The old theme seems to be hardwired now. Even if I delete the chrome folder, Firefox won't revert back to its original look. I wonder if this is an issue with Flatpak or firefox.

acch commented 5 years ago

Great @rafaelmardojai - thanks for your efforts!

Looks promising. Maximized firefox windows look perfect. However, with non-maximized windows the tabs seem to be too high and overlap the address bar for me: image

...but that's just a minor glitch. Firefox Gnome Theme is usable for me again. BTW I'm in Arch Linux, Firefox 65.0.1

rafaelmardojai commented 5 years ago

@acch Fixed!

acch commented 5 years ago

Awsome! Looks flawless to me.

rafaelmardojai commented 5 years ago

@Saroufim i installed Firefox flatpak (https://firefox-flatpak.mojefedora.cz) and theme works like expected.