search

lunaneff / gnome-shell-extension-zenbook-duo

GNU General Public License v3.0
14 stars 10 forks source link

Gnome 43 #10

Open adasauce opened 1 year ago

adasauce commented 1 year ago

The extension doesn't seem to work after gnome updated from 42 -> 43.

I tried changing the manifest to enable 43 to see if it would still work, but it didn't.

I meant to open this issue when i had more context around the errors that were happening but it was a week or so ago and only getting to opening the issue now, sorry.

I hope I can run some tests again to get more data.

adasauce commented 1 year ago

Sorry it took so long to get to!

Here's the exception thrown in the logs:

JS ERROR: Extension zenbook-duo@laurinneff.ch: TypeError: imports.ui.main.panel.statusArea.aggregateMenu is undefined
                                         enable@/home/me/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/extension.js:220:9
                                         _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:184:32
                                         loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:385:26
                                         _loadExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:633:18
                                         collectFromDatadirs@resource:///org/gnome/shell/misc/fileUtils.js:28:28
                                         _loadExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:612:19
                                         _enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:639:18
                                         _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:659:14
                                         init@resource:///org/gnome/shell/ui/extensionSystem.js:57:14
                                         _initializeUI@resource:///org/gnome/shell/ui/main.js:309:22
                                         start@resource:///org/gnome/shell/ui/main.js:186:5
                                         @resource:///org/gnome/shell/ui/init.js:6:17
mjollnir14 commented 1 year ago

GNOME Shell 43 removed aggregateMenu and uses quick settings instead:

https://gjs.guide/extensions/upgrading/gnome-shell-43.html#quick-settings

mjollnir14 commented 1 year ago

Here's a Gnome 43 compatible fork of Laurinneff project:

https://github.com/mjollnir14/gnome-shell-extension-zenbook-duo

Feel free to merge it

Tested on Ubuntu 22 / Xorg and Wayland

edit: wrong url