search

lunaneff / gnome-shell-extension-zenbook-duo

GNU General Public License v3.0
14 stars 10 forks source link

Submit to ego? #3

Closed jibsaramnim closed 2 years ago

jibsaramnim commented 2 years ago

Do you think there would be anything preventing you from having the extension submitted to and published on the GNOME extensions site? It might make it even nicer for people if they can just enable it from the site, rather than having to build it themselves. Of course it still requires the kernel module, so it won't be a total breeze, but it'll be a little more convenient, and perhaps having the added exposure would help more people discover that this extension is actually available too.

lunaneff commented 2 years ago

I don't see anything on the link you posted, but I feel like it might be rejected because it writes directly to sysfs. I can ask the GNOME team on Matrix if that's fine or not

lunaneff commented 2 years ago

Someone linked cpupower as an example of how it could be done, it asks for a password to install a polkit rule on installation, and after that it uses polkit to elevate privileges when writing to sysfs. I could try to implement something similar this evening

lunaneff commented 2 years ago

I implemented this now. But I've read the guidelines again and noticed that extensions need to have an OSI-approved license, but this extension currently doesn't have a license. @jibsaramnim, since you already contributed I have to ask for legal reasons, would you be OK with relicensing to the GPL3?

jibsaramnim commented 2 years ago

That's 100% ok with me yes! :)

lunaneff commented 2 years ago

I submitted the extension now. If anyone wants to follow the review process, here

lunaneff commented 2 years ago

It got rejected, but I fixed the issues and the new review is here

lunaneff commented 2 years ago

This time it got approved, the extension is published here

jibsaramnim commented 2 years ago

image

This is so nice, it's automatically updating my manually compiled/installed version. What a pleasant experience. Thanks so much for adding this to ego, I hope it'll help a lot more ZenBook Duo folk, especially now that you've added some great new features to boot!