search

lunaneff / gnome-shell-extension-zenbook-duo

GNU General Public License v3.0
14 stars 10 forks source link

New eog version does not install additional files #5

Closed jibsaramnim closed 2 years ago

jibsaramnim commented 2 years ago

It seems like after automatically having the extension updated to the eog version, the installation step is not triggered (presumably because the extension was already considered installed previously), but this seems to break the functionality of the extension, as it is unable to located required files (e.g. /usr/local/bin/screenpad-$USER). Or at least I think that's what happened?

Attached are the journal logs I could find, this is after attempting to press the disable secondary screen button and adjusting the brightness (neither of which actually worked, of course):

JS ERROR: GLib.SpawnError: Failed to execute child process “/usr/local/bin/screenpad-davejansen” (No such file or directory)
runScreenpadTool/<@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/utils.js:104:29
runScreenpadTool@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/utils.js:93:12
_getBrightness@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/extension.js:287:33
enable/this._brightnessListenerId<@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/extension.js:223:37
set value@resource:///org/gnome/shell/ui/barLevel.js:59:14
_changeSlider@resource:///org/gnome/shell/ui/status/brightness.js:63:9
_sync@resource:///org/gnome/shell/ui/status/brightness.js:71:18

JS ERROR: GLib.SpawnError: Failed to execute child process “/usr/local/bin/screenpad-davejansen” (No such file or directory)
runScreenpadTool/<@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/utils.js:104:29
runScreenpadTool@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/utils.js:93:12
_getBrightness@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/extension.js:287:33
enable/this._brightnessListenerId<@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/extension.js:223:37
set value@resource:///org/gnome/shell/ui/barLevel.js:59:14
_changeSlider@resource:///org/gnome/shell/ui/status/brightness.js:63:9
_sync@resource:///org/gnome/shell/ui/status/brightness.js:71:18

JS ERROR: GLib.SpawnError: Failed to execute child process “/usr/local/bin/screenpad-davejansen” (No such file or directory)
runScreenpadTool/<@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/utils.js:104:29
runScreenpadTool@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/utils.js:93:12
_getBrightness@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/extension.js:287:33
enable/this._brightnessListenerId<@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/extension.js:223:37
set value@resource:///org/gnome/shell/ui/barLevel.js:59:14
_changeSlider@resource:///org/gnome/shell/ui/status/brightness.js:63:9
_sync@resource:///org/gnome/shell/ui/status/brightness.js:71:18

JS ERROR: GLib.SpawnError: Failed to execute child process “/usr/local/bin/screenpad-davejansen” (No such file or directory)
runScreenpadTool/<@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/utils.js:104:29
runScreenpadTool@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/utils.js:93:12
_getBrightness@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/extension.js:287:33
enable/this._brightnessListenerId<@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/extension.js:223:37
set value@resource:///org/gnome/shell/ui/barLevel.js:59:14
_changeSlider@resource:///org/gnome/shell/ui/status/brightness.js:63:9
_sync@resource:///org/gnome/shell/ui/status/brightness.js:71:18

JS ERROR: GLib.SpawnError: Failed to execute child process “/usr/local/bin/screenpad-davejansen” (No such file or directory)
runScreenpadTool/<@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/utils.js:104:29
runScreenpadTool@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/utils.js:93:12
_getBrightness@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/extension.js:287:33
enable/this._brightnessListenerId<@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/extension.js:223:37
set value@resource:///org/gnome/shell/ui/barLevel.js:59:14
_changeSlider@resource:///org/gnome/shell/ui/status/brightness.js:63:9
_sync@resource:///org/gnome/shell/ui/status/brightness.js:71:18

JS ERROR: GLib.SpawnError: Failed to execute child process “/usr/local/bin/screenpad-davejansen” (No such file or directory)
runScreenpadTool/<@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/utils.js:104:29
runScreenpadTool@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/utils.js:93:12
_getBrightness@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/extension.js:287:33
enable/this._brightnessListenerId<@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/extension.js:223:37
set value@resource:///org/gnome/shell/ui/barLevel.js:59:14
_changeSlider@resource:///org/gnome/shell/ui/status/brightness.js:63:9
_sync@resource:///org/gnome/shell/ui/status/brightness.js:71:18

JS ERROR: GLib.SpawnError: Failed to execute child process “/usr/local/bin/screenpad-davejansen” (No such file or directory)
runScreenpadTool/<@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/utils.js:104:29
runScreenpadTool@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/utils.js:93:12
_getBrightness@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/extension.js:287:33
enable/this._brightnessListenerId<@/home/davejansen/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/extension.js:223:37
set value@resource:///org/gnome/shell/ui/barLevel.js:59:14
_changeSlider@resource:///org/gnome/shell/ui/status/brightness.js:63:9
_sync@resource:///org/gnome/shell/ui/status/brightness.js:71:18
jibsaramnim commented 2 years ago

Quick follow-up; it does not seem to be specific to when you're upgrading from a self-installed version. After having removed the extension completely, logged out and back in, I re-installed the extension but it still does not seem to trigger the installation of the /usr/local/bin/screenpad-$USER file. Perhaps the entire install() method is not triggered, somehow?

Edit: I can confirm that when I manually install the accompanying tool, the extension starts working right away. I ran sudo ./installer.sh --prefix /usr --suffix $USER --extension-path ../ install from the scripts folder inside where the extension is installed (~/.local/share/gnome-shell/extensions/zenbook-duo@laurinneff.ch/scripts/)

lunaneff commented 2 years ago

That's strange, it should've shown a notification to install when it's enabled the first time after a gnome-shell restart. I'll see if I can figure it out

lunaneff commented 2 years ago

Easy fix, I moved the firstRun variable to be a class member but forgot to set it to true in the constructor

lunaneff commented 2 years ago

The update is out on EGO now

jibsaramnim commented 2 years ago

Awesome, you're lightning fast! I just had a change to boot up my laptop and after logging out and back in I got the additional step notification, entered my password, and then success notification! I didn't try this after first uninstalling the extension, but everything is still working after this update at least. Thank you again! :)