search

lunaneff / gnome-shell-extension-zenbook-duo

GNU General Public License v3.0
14 stars 10 forks source link

Added GNOME 42 compatibility #6

Closed jibsaramnim closed 2 years ago

jibsaramnim commented 2 years ago

GNOME 42 is out, and your wonderful extension seems to be working great with it, still. I've tested it with the just-released Fedora 36. I have not tested it with Ubuntu 22.04 and the Pop_Os! equivalent, but I suspect it will run just as well there, too.

I've also gone ahead and bumped the version, but please let me know if I shouldn't do that for these kinds of updates.

Thank you!

lunaneff commented 2 years ago

Thanks! I'd have done this myself a lot earlier, but I've switched to Fedora Silverblue since the last update and haven't figured out how to install the kernel module on there yet, so I wasn't able to test.

As for the version bump, that's ok, I'd have had to bump it myself anyway

lunaneff commented 2 years ago

Submitted to EGO: https://extensions.gnome.org/review/32240

jibsaramnim commented 2 years ago

I've switched to Fedora Silverblue since the last update and haven't figured out how to install the kernel module on there yet

Oh interesting, I had been curious about trying out Silverblue too, but not having the module available would be quite a big limitation for me. I wonder if it would require packaging up the kernel module so you could rely on rpm-ostree to have it installed and working?

I'm still on Fedora Workstation on both my main machine and Zenbook, so have no direct experience with Silverblue yet. I suppose that may stay this way too, as it sounds nice in theory but in practice it just would end up requiring extra fiddling to get things working. And if there's one thing I'd rather not spend my time on.. :D

Thanks for approving the PR and for submitting the extension update!

lunaneff commented 2 years ago

Yeah packaging it as RPM would probably work, but I have no experience with that since I'm still pretty new to RPM-based distros (came from Arch and Debian-based before that)

As for fiddling, yeah some things (mostly just IDEs) require a bit of work, but it's not too bad IMO. And in some cases (like GNOME Builder) everything works out of the box since it integrates Flatpak really well