search

lunapaint / vscode-luna-paint

A raster image editor extension for VS Code
https://marketplace.visualstudio.com/items?itemName=Tyriar.luna-paint
279 stars 25 forks source link

New Icon/Image command fails when no folder is opened #107

Closed MikeTheGreat closed 2 years ago

MikeTheGreat commented 2 years ago

Thank you for creating this free, open source image editor for VSCode!

I'm on Windows 10, and having just installed Luna Paint into VSCode when I run the New Icon command (via the command palette) it asks me for the width & height ( I go with the default 256x256) and then I get the following error:

image

This seems not great so I figured I'd let y'all know.

I confirmed that the directory does exist.
It's weird that the error message is talking about a relative path but the listed path is absolute (starts with C:).

Tyriar commented 2 years ago

Hmm I've never seen this and can't reproduce, can you give some more details about what type of window you're running this in? A gif of the whole window with the explorer showing would probably give me enough information.

Tyriar commented 2 years ago

Oh I can reproduce, it happens when opening in a window without a folder opened.

onmax commented 2 years ago

Oh I can reproduce, it happens when opening in a window without a folder opened.

It happens the same to me, but trying to create an image instead of an icon

Tyriar commented 2 years ago

Looks like this is a regression in VS Code, will report soon

Tyriar commented 2 years ago

Reported to https://github.com/microsoft/vscode/issues/137524, nothing to do here after reviewing the code.

Tyriar commented 2 years ago

This actually is an issue with a misuse of Uri.parse, reopening