search

lunapaint / vscode-luna-paint

A raster image editor extension for VS Code
https://marketplace.visualstudio.com/items?itemName=Tyriar.luna-paint
279 stars 25 forks source link

Editor association with *.{png} has no effect #129

Closed carstenschwede closed 2 years ago

carstenschwede commented 2 years ago

Thanks for a great extension, it works well with .jpegs, however I can't get it to open .png files as well, despite adding

    "workbench.editorAssociations": {
        "*.{bmp,ico,jpg,jpeg,png}": "luna.editor"
  }

to the settings. Is there any other place where I have to assign luna.editor to open .png files?

VSCode Version: 1.63.2 on macOS 12.1 Luna Paint Version: 0.12.0

carstenschwede commented 2 years ago

Interesting, using this

  "workbench.editorAssociations": {
        "*.png": "luna.editor",
        "*.bmp": "luna.editor",
        "*.jpeg": "luna.editor",
        "*.jpg": "luna.editor",
        "*.ico": "luna.editor"
    }

works for all mentioned filetypes (including pngs).

But this doesn't work for pngs (but does for jpegs)?

"workbench.editorAssociations": {
        "*.{bmp,ico,jpg,jpeg,png}": "luna.editor"
  }

Probably the *.{} syntax is ignored and the .jpe?g association is defined elsewhere?

Tyriar commented 2 years ago

That's odd, this is what I have right now which works fine:

  "workbench.editorAssociations": {
    "*.{bmp,ico,jpg,jpeg,png}": "luna.editor",
    "*.webp": "luna.editor",
    "*.jpe": "luna.editor",
    "*.ipynb": "jupyter-notebook"
  },

I'm guessing this is a problem in VS Code, not the extension. @lramos15 any idea what could be causing this?

carstenschwede commented 2 years ago

Thanks for the fast response. I happened to have a conflicting entry in my user settings, which for some reason won't get replaced if I use the *.{png} pattern in my workspace settings:

User settings.json:

"workbench.editorAssociations": {
    "*.png": "imagePreview.previewEditor"
}

Workspace .vscode/settings.json which does not work:

"workbench.editorAssociations": {
    "*.{png}": "luna.editor"
}

Workspace .vscode/settings.json which does work:

"workbench.editorAssociations": {
    "*.png": "luna.editor"
}

Could you check if you can replicate this issue by adding a corresponding entry in your user (not workspace) settings? I am not sure why the culy bracket glob pattern does not work. I removed workbench.editorAssociations from both (user + workspace) settings and it now works without specifying any associations explicitly.

Tyriar commented 2 years ago

Thanks for the extra info, I moved this over to the VS Code repo: https://github.com/microsoft/vscode/issues/141286