search

lunapaint / vscode-luna-paint

A raster image editor extension for VS Code
https://marketplace.visualstudio.com/items?itemName=Tyriar.luna-paint
279 stars 25 forks source link

Luna Paint fails to save PNG #194

Closed CodaKidGit closed 11 months ago

CodaKidGit commented 12 months ago

Issue: Sometimes when a user tries to save their .png image after editing it, Luna Paint won't save the image. No errors appear on screen, but the unsaved circle never goes away even after using the shortcut to save, click File > Save, or even File > Save All. Java Files open in the same workspace save correctly.

Steps to Reproduce:

  1. Open a .png file in Luna Paint.
  2. Make it messy. Unfortunately, I am not sure at this time what exactly causes the issue. I can't seem to reproduce myself, but I have seen it many times on other student's computers.
  3. Attempt to save. Nothing will happen upon hitting the save button.

Let me know if there is any more information I can try to grab you next time I see the issue.

Mqxx commented 11 months ago

I had the same problem that I needed to hit the save button 2 times in a row to get the image saved. This problem also happens in the draw.io extension. I am not sure maybe it is one of the vs code APIs that causes this.

Tyriar commented 11 months ago

FYI @mjbvz, I've seen this reported a few times in this repo and on twitter. Likely an issue with custom editors. cc @tyaginidhi

tyaginidhi commented 11 months ago

This is similar to the issue I have noticed - though in our case its consistent - we do not get call to our fileSystemProvider writeFile call for the save flow to be triggered: https://github.com/lunapaint/vscode-luna-paint/issues/192

Tyriar commented 11 months ago

Thanks @tyaginidhi, closing this off in favor of the internal tracking issue as it's a problem in core. Hopefully it'll get fixed soon