Saving an unchanged file causes change on disk

lunapaint / vscode-luna-paint

A raster image editor extension for VS Code

https://marketplace.visualstudio.com/items?itemName=Tyriar.luna-paint

282 stars 27 forks source link

Saving an unchanged file causes change on disk #36

Closed lramos15 closed 3 years ago

lramos15 commented 3 years ago

Open an image in luna paint
Save it right after opening
🐛 SCM view says the file has changed on disk

What's expected is that nothing happens since the file is not dirty.

Tyriar commented 3 years ago

What's happening is it's just saving it again with different encoding that it originally used so the bits end up different. I think you're right and I'll just block that from happening for non-dirty images.

lramos15 commented 3 years ago

Is there a specific reason the encoding is changing? I would expect Luna paint to try to preserve the encoding but I also don't know if changing it is a requirement to allow editing.

Tyriar commented 3 years ago

@lramos15 currently there are no encoding options, Chromium handles all the saving. I'm just starting to get into that now with .ico (which is a container for .png and .bmp).