lunapaint / vscode-luna-paint

A raster image editor extension for VS Code
https://marketplace.visualstudio.com/items?itemName=Tyriar.luna-paint
282 stars 27 forks source link

Temp hand tool, springs back after having "center to rectangle" zoomed #77

Closed duianto closed 3 years ago

duianto commented 3 years ago

Issue Type: Bug

Panning the canvas with the temp hand tool (space held), with the zoom tool selected, after having drawn a "center to rectangle" (from bottom right to top left).

Causes the canvas to spring back to the pre-pan location, when the left mouse button is released.

Update:

It also happens after zooming in with the zoom tool, by drawing a zoom rectangle from the top left to the bottom right.

But another issue occurs if the zoom tool just is left or right mouse button clicked, before temp hand panning.

When the canvas is temp hand panned a small amount, then the canvas is zoomed a little bit.

But when temp hand panning a longer distance, then the zoom level becomes Infinity%.

Reproduction steps

  1. Select the zoom tool (z).
  2. Draw a "center to rectangle" (from bottom right to top left)
  3. Hold down the space key.
  4. Left mouse button drag in any direction.
  5. Release the Left mouse button.

Actual Behavior

The canvas returns to it's pre-pan location.

temp_hand_springs_back

Expected

The canvas does not spring back when temp panning with the other tools. It should probably behave the same after having drawn a "center to rectangle" with the zoom tool.

Extension version: 0.6.0 VS Code version: Code 1.57.0 (b4c1bd0a9b03c749ea011b06c6d2676c8091a70c, 2021-06-09T17:18:42.354Z) OS version: Windows_NT x64 10.0.19043 Restricted Mode: Yes

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i3-2100 CPU @ 3.10GHz (4 x 3093)| |GPU Status|2d_canvas: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: unavailable_off
opengl: enabled_on
rasterization: unavailable_off
skia_renderer: enabled_on
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled| |Load (avg)|undefined| |Memory (System)|11.96GB (7.17GB free)| |Process Argv|--crash-reporter-id 59a302e3-5caa-4bda-8390-b451e1103e43| |Screen Reader|no| |VM|0%|
A/B Experiments ``` vsliv368cf:30146710 vsreu685:30147344 python383:30185418 pythonvspyt602:30300191 vspor879:30202332 vspor708:30202333 vspor363:30204092 pythonvspyt639:30300192 pythontb:30283811 pythonvspyt551cf:30311713 vspre833:30267464 pythonptprofiler:30281270 vshan820:30294714 pythondataviewer:30285071 vscus158cf:30286554 vscgsv2:30307504 vscorehovct:30309550 vscod805:30301674 binariesv517:30312825 ```