lunapaint / vscode-luna-paint

A raster image editor extension for VS Code
https://marketplace.visualstudio.com/items?itemName=Tyriar.luna-paint
282 stars 27 forks source link

Welcome tutorial typos #88

Closed duianto closed 3 years ago

duianto commented 3 years ago

Some possible typos in the welcome tutorial: Edit Images With Luna Paint

Selection Tools

Last sentence

When manipulating the selection it has a blue hue, when moving pixels the selection will goes transparent so the end result of the move/scale action is more clear.

Result:

When manipulating the selection it has a blue hue, when moving pixels the selection becomes transparent, so that the end result of the move/scale action is clear.

Line Tool

Third paragraphs, first sentence

When a line is drawn, handles appear which allow manipulating the line's.

Result:

When a line is drawn, handles appear which allow for manipulating the line.

Fourth paragraph

Among the options is smoothing which will disable anti-aliasing, when smoothing is disabled and stroke width is 1px the tool uses a special drawing mode that results in a pixel perfect line and guide.

Result:

Among the options is smoothing which will disable anti-aliasing, when smoothing is disabled and stroke width is 1px, then the tool uses a special drawing mode that results in a pixel perfect line and guide.

Color Picker Tool

First sentence

The Color Picker tool, also known as the eye dropper, allows sampling a layer's individual pixels for their color.

Result:

The Color Picker tool, also known as the eye dropper, allows for sampling a layer's individual pixels for their color.

Second sentence

 Left click will put set the primary color and right click will set the secondary color.

Result:

Left click will set the primary color and right click will set the secondary color.

Third sentence

Change the sampling option in the top bar allows picking the average of colors over a range of pixels.

Result:

Change the sampling option in the top bar, to pick the average color over a range of pixels.

Viewport Tools

Hand Tool

Second Sentence

ℹ️ Panning the viewport can also be done using the mouse wheel (vertical) and shift+mouse wheel.

Result:

ℹ️ Panning the viewport can also be done using the mouse wheel (vertical) and shift+mouse wheel (horizontal).

Zoom Tool

First sentence

The Zoom tool allows zooming the viewport in with left click and zooming out with right click.

Result:

The Zoom tool allows for zooming the viewport with left click and zooming out with right click.

Third sentence

ℹ️ The setting "luna.mouseWheelBehavior": "zoom" can be used to make the mouse wheel's zoom without holding ctrl/⌘

Result:

ℹ️ The setting "luna.mouseWheelBehavior": "zoom" can be used to make the mouse wheel zoom without holding ctrl/⌘

Shape Tool

Third sentence

When a shape is drawn, handles appear which allow manipulating the shape's dimensions. Various options are available to configure how the shape is drawn.

Result:

When a shape is drawn, handles appear which allow for manipulating the shape's dimensions. Various options are available to configure how the shape is drawn.

Fourth sentence

Among the options is smoothing which will disable anti-aliasing, when smoothing is disabled and stroke width is 1px the tool uses a special drawing mode that results in pixel-perfect shapes contained within the rectangle.

Result:

Among the options is smoothing which will disable anti-aliasing, when smoothing is disabled and stroke width is 1px, then the tool uses a special drawing mode that results in pixel-perfect shapes contained within the rectangle.

Text Tool

First sentence

The Text tool allows drawing text within the canvas, left click will use the primary color and right click will use the secondary color.

Result:

The Text tool allows for drawing text within the canvas, left click will use the primary color and right click will use the secondary color.

Third sentence

When text is drawn, handles appear which allow manipulating the text's dimensions. The following options are available to configure how the text is drawn:

Result:

When text is drawn, handles appear which allow for manipulating the text's dimensions. The following options are available to configure how the text is drawn:
Tyriar commented 3 years ago

Love it 🙂, will go through these for 0.9

Tyriar commented 3 years ago

Thanks, I changed most of these. I didn't do the "allows for" because I believe both are valid and the previous way sounds more natural to me. This might be aus vs us preference? Not sure where you're from 🙂

duianto commented 3 years ago

It's fine you should write the way you feel comfortable with.

It just sounded to me, like something was missing between "allow" and "manipulating".

But your right, it depends on what we're used to.

Searching on google for:

So there are lots of uses of both variants.

And for example: languagetool.org says: Looks good. No mistakes were found. with or without "for" between "allow" and "manipulating" in the sentence:

When text is drawn, handles appear which allow manipulating the text's dimensions. The following options are available to configure how the text is drawn:

I believe both are valid

👍