search

lunar-sway / minestuck

A Homestuck Minecraft mod
Other
54 stars 65 forks source link

Cruxite blocks #573

Closed glubtier closed 7 months ago

glubtier commented 8 months ago

Added cruxite block set, derivative blocks, and recipes.

Textures: raw block - Rose smooth block - Sipher Polished, bricks, chiseled, door, trapdoor, lamp, pillar - Glubtier

glubtier commented 8 months ago

By raw block, I assume you mean the original cruxite_block one. You should probably add the retexture of that block to the changelog. You should also plan with akisephila how the cruxite block retexture conflict between this and #572 should be handled.

Correct, it's just called "CRUXITE_BLOCK" in code but they're all cruxite blocks, which is why I specified.

I think we both have the same file there, if Aki pulled from Rose's branch, but I'll ask.

glubtier commented 8 months ago

Updated recipes and corrected some conflicts with block tags, but it's failing the build on GitHub now, not sure why? I tried runData again and there's nothing changed, nothing unversioned, etc.

Dweblenod commented 8 months ago

Updated recipes and corrected some conflicts with block tags, but it's failing the build on GitHub now, not sure why? I tried runData again and there's nothing changed, nothing unversioned, etc.

In the cases where it fails and you cant see where, open Details! Heres a part of the error that seems relevant /home/runner/work/minestuck/minestuck/src/main/java/com/mraof/minestuck/data/MSBlockStateProvider.java:1766: error: cannot find symbol if(state.getValue(CustomLampBlock.CLICKED) ) { ^ symbol: variable CustomLampBlock location: class MSBlockStateProvider

glubtier commented 8 months ago

In the cases where it fails and you cant see where, open Details! Heres a part of the error that seems relevant /home/runner/work/minestuck/minestuck/src/main/java/com/mraof/minestuck/data/MSBlockStateProvider.java:1766: error: cannot find symbol if(state.getValue(CustomLampBlock.CLICKED) ) { ^ symbol: variable CustomLampBlock location: class MSBlockStateProvider

Alright well I'm bamboozled on this because I didn't change those files at all, and I can't replicate it on my end so I'll have to fiddle with it more tomorrow.

Unrelated to that, I have just now committed a change to MSBlockStateProvider. I forgot I hardcoded CRUXITE_LAMP into customLampWithItem. It is no longer hard coded.

kirderf1 commented 8 months ago

Ooh, this is a peculiar issue for sure. There are non-conflicting changes that causes the build to fail. Just merge upcoming-content and you should see the issue you need to resolve.

glubtier commented 8 months ago

Ooh, this is a peculiar issue for sure. There are non-conflicting changes that causes the build to fail. Just merge upcoming-content and you should see the issue you need to resolve.

Okay that seemed to work. :)