search

lunar-sway / minestuck

A Homestuck Minecraft mod
Other
54 stars 64 forks source link

Adding Trees, Treeblocks, and Signs #596

Closed glubtier closed 4 months ago

glubtier commented 5 months ago

Signs: Probably the biggest addition here. Required the creation of several classes. Of those, I was unsure if I put some in the right place- entity.MSBlockEntities - Actually not sure if there already was a class that serves the same purpose? But I couldn't find it. util.MSWoodTypes - Necessary for signs but not sure if it's better put in util or data or somewhere else.

MSWoodTypes: These are not threadsafe and need to go in enqueueWork, so I added them to mainThreadSetup(). It looks kind of clunky but this is fairly standard implementation, based on other mod repos I've poked around. I think there are better ways, but that's the kind of work I'd like to save for another post-4/13 PR, unless someone is chomping at the bit to take it on now.

End log: I'm not entirely sure what the design intent with the "double log" block was, but in the interest of not reinventing the wheel, I matched the stripped variant to this, and added a third texture for both log and stripped log blocks. (Lovingly named end_log_triple :) For now.) After 4/13, I plan on giving End lands a facelift like we're doing with some of the other lands.

Also as such, the model, blockstate, and item files for the stripped_end_log are hard-coded, like the end_log already is.

MSCreativeTabs: I tried to put all the related tree blocks together, in a similar order to the way vanilla tree blocks are ordered.

MSBlockStateProvider: small change to how the render type is applied to doors.

MSBlockSetType: I added all the woods, as well as all the stones that I could sus out, but I may have missed some. I did not update the BlockSetTypes for anything but the trees/woods I was working on.

Texture Credits:

(see also: https://docs.google.com/document/d/1MON4wpOaZjSfU_PFoJ_unIyOCggCKknxfZ96HZTj4x0/edit?usp=sharing)

kirderf1 commented 5 months ago

Changelog is also a thing. I assume that additions won't be a problem, but we should take extra care with changes (textures, models and the like) so that we catch changes to preexisting blocks (blocks that have already been released, like frost leaves and shadewood).

kirderf1 commented 5 months ago

It also looks like you merged content from the 1.20.1 branch, trying to push those changes to upcoming-content is not the best thing to do here. We can discuss how to remedy that on discord!

It doesn't matter much in this occurrence. Everything in 1.20.1 already exists in upcoming-content. I imagine that the changes from 1.20.1 will disappear from the diff once the merge conflicts with upcoming-content has been resolved.

glubtier commented 5 months ago

Changelog is also a thing. I assume that additions won't be a problem, but we should take extra care with changes (textures, models and the like) so that we catch changes to preexisting blocks (blocks that have already been released, like frost leaves and shadewood).

Yep! Once I'm actually done with textures and know what is and isn't going in, then I have to go through them all. I'll update the changelog and credits after that.

glubtier commented 5 months ago

It also looks like you merged content from the 1.20.1 branch, trying to push those changes to upcoming-content is not the best thing to do here. We can discuss how to remedy that on discord!

It doesn't matter much in this occurrence. Everything in 1.20.1 already exists in upcoming-content. I imagine that the changes from 1.20.1 will disappear from the diff once the merge conflicts with upcoming-content has been resolved.

This might also be because I had some file issues on my PC and then some merging shenanigans in my own repo. Future PRs shouldn't have any issue but if you have any tips, I'm happy to hear them. GitHub (the site itself) doesn't always make sense to me.

Dweblenod commented 4 months ago

Was there any other changes you intended to make to this @glubtier?

glubtier commented 4 months ago

Was there any other changes you intended to make to this @glubtier?

Yes, I'm working on adding all the tree growers and adding them to lands, gathering all the credits, and any other changes I was asked to make! (I can't check cause I'm on my phone)

glubtier commented 4 months ago

@kirderf1 Credits! https://docs.google.com/document/d/1MON4wpOaZjSfU_PFoJ_unIyOCggCKknxfZ96HZTj4x0/edit?usp=sharing

I tried to note down which textures are new, which ones were modified, which ones were repurposed, etc. I don't care about credits for anything I color-corrected or did some light reshading/retouching, I just included them to be thorough. If I missed something or something is unclear, please DM me!

glubtier commented 4 months ago

As of now, everything I intended to do is done, short of any fixes or merge conflicts.