search

lunar-sway / minestuck

A Homestuck Minecraft mod
Other
54 stars 65 forks source link

PlayerData data attachments #610

Closed kirderf1 closed 5 months ago

kirderf1 commented 6 months ago

The goal is to convert most (potentially all) data in PlayerData into attachments, as well as doing general code cleanup on code adjacent to this data.

I'm also considering renaming PlayerData to reflect it being available even when the player is offline.

The same treatment could be given to SburbPlayerData (and moving some data from it over to PlayerData), but I'll leave it for a future PR to limit the scope of this one.

As Minestuck hasn't been released for Minecraft 1.20.4 yet, I am not attempting to keep backwards-compatibility for these changes.

kirderf1 commented 5 months ago

This should be ready for review.

I didn't get any specific ideas for renaming PlayerData/PlayerSavedData. If anyone has any thoughts, feel free to add them through a review.