Plantable saplings, frost leaves drop saplings, tag changes to woods

lunar-sway / minestuck

A Homestuck Minecraft mod

Other

54 stars 64 forks source link

Plantable saplings, frost leaves drop saplings, tag changes to woods #615

Closed glubtier closed 3 months ago

glubtier commented 4 months ago

Saplings were made pottable
Frost leaves drop saplings and flowering frost leaves are available in creative tabs, as is the case with azalea/flowering azalea
Corrected various wood-related tags, mostly aspect, to allow for crafting of certain items such as composters
Modified Space aspect sapling texture

kirderf1 commented 4 months ago

Do you want this released in a small update on 1.20.1, or should this go in somewhere over on 1.20.4?

glubtier commented 4 months ago

Do you want this released in a small update on 1.20.1, or should this go in somewhere over on 1.20.4?

1.20.1 would probably be better, it technically should have been part of the trees release.

glubtier commented 4 months ago

Snuck in a tiny little change to add wooden Slabs to the appropriate tags

kirderf1 commented 4 months ago

Looks like you accidentally deleted the entire "generated" folder in the last commit.

glubtier commented 4 months ago

Looks like you accidentally deleted the entire "generated" folder in the last commit.

oh gosh I did delete the generated folder for unrelated issues and regenerated, and it looks like it only pushed the delete. Hopefully this fixes it.

glubtier commented 4 months ago

@kirderf1 I updated the PR. I included the space sapling there, but didn't add it to the change log... it was two pixels removed from each side so that it wouldn't stick out the sides of the pot. It felt a little cheeky to put it in the changelog lol. But I can if you think it's important!

kirderf1 commented 4 months ago

I included the space sapling there, but didn't add it to the change log... it was two pixels removed from each side so that it wouldn't stick out the sides of the pot. It felt a little cheeky to put it in the changelog lol. But I can if you think it's important!

Looks like the texture was also moved vertically. If nothing else, I think that deserves to be added to the "Fixed" part of the changelog.

glubtier commented 4 months ago

I included the space sapling there, but didn't add it to the change log... it was two pixels removed from each side so that it wouldn't stick out the sides of the pot. It felt a little cheeky to put it in the changelog lol. But I can if you think it's important!

Looks like the texture was also moved vertically. If nothing else, I think that deserves to be added to the "Fixed" part of the changelog.

Oh... uh, huh. I was working off my work folder, I guess I changed it but forgot to upload it before the 4/13 update lol. Sure I'll add that.

glubtier commented 3 months ago

Excellent work! I do have a few comments.

* It looks like all the potted blocks should be added to the minecraft block tag "flower_pots"

* The base of the frost saplings stick out of the pot a little bit. Im fine with it staying as is but thought I would point it out.

ty, I can look at the tags later tonight, but until then do you have a screenshot of the frost sapling? I believe you, it just doesn't show that way on my screen.

Dweblenod commented 3 months ago

Excellent work! I do have a few comments.
* It looks like all the potted blocks should be added to the minecraft block tag "flower_pots"

* The base of the frost saplings stick out of the pot a little bit. Im fine with it staying as is but thought I would point it out.
ty, I can look at the tags later tonight, but until then do you have a screenshot of the frost sapling? I believe you, it just doesn't show that way on my screen.