search

lunarmodules / Penlight

A set of pure Lua libraries focusing on input data handling (such as reading configuration files), functional programming (such as map, reduce, placeholder expressions,etc), and OS path management. Much of the functionality is inspired by the Python standard libraries.
https://lunarmodules.github.io/Penlight/
MIT License
1.93k stars 241 forks source link

penlight 1.14 is rockspec_revision 1, but uses rockspec_revision 3 feature issues_url this breaks on luarocks-5.1 since it does not support rockspec 3 #475

Closed creel904 closed 6 months ago

creel904 commented 6 months ago

error: failed installing penlight-1.14.0-1.rockspec: unknown field issues_url

You can see here: https://github.com/luarocks/luarocks/wiki/Rockspec-format description.issues_url (string) (since 3.0) - An URL for the project's issue tracker.

so either 1.14 needs to have its rockspec changed to rockspec revision 3,

or

remove issues_url from 1.14 rockspec file so that it is compliant with rockspec 1.

to recreate error: luarocks-5.1 install penlight

alerque commented 6 months ago

For many other Lua projects I've been managing I've been using rockspec 3 for the rcs/dev rockspec and a template script that modifies the current dev rockspec and strips out the v3 manifest features and post a v1 rockspec for releases. The issues_url is a minor improvement, but being able to call out test dependencies and runners is quite nice.

I'm sure this field slipped a cog at release time, a rockrel-2 should do the job.

piotr-piatkowski commented 6 months ago

I have similar issue but different error:

# luarocks install penlight
Installing https://raw.githubusercontent.com/rocks-moonscript-org/moonrocks-mirror/master/penlight-1.14.0-1.src.rock...
Using https://raw.githubusercontent.com/rocks-moonscript-org/moonrocks-mirror/master/penlight-1.14.0-1.src.rock... switching to 'build' mode

Error: /tmp/luarocks_penlight-1.14.0-1-1386/penlight-1.14.0-1.rockspec: Unknown field test
Tieske commented 6 months ago

version 1.14.0-2 is up on LuaRocks!