search

lunarmodules / busted

Elegant Lua unit testing.
https://lunarmodules.github.io/busted/
MIT License
1.4k stars 185 forks source link

fix source URL in rockspec for v2.0.0 release #601

Closed zackse closed 5 years ago

zackse commented 5 years ago

As of the new release, the version referenced in the rockspec file's source URL is inaccessible. This commit changes it to match the tarball version on github (no -0 suffix). I'm not sure if this is preferable to renaming the archive and its contained directory, but it works in local testing.

Tieske commented 5 years ago

the tags in the git-repo should NOT contian the LuaRocks rockspec revision number. So this change is valid.

But to get this done, the rockspec should be renamed with an incremented LR revision number; -1 in this case. And then that rockspec should be pushed/published to the LuaRocks server.

Tieske commented 5 years ago

(the quick and dirty fix would be to create another tag 2.0.0-0 (on the same commit as currently tagged 2.0.0)

Tieske commented 5 years ago

replaced by #603

Tieske commented 5 years ago

this can be closed now since #603 was merged

zackse commented 5 years ago

Thanks for the quick fix in #603.