Link broken on busted 2.0.0 installation via Luarocks

lunarmodules / busted

Elegant Lua unit testing.

https://lunarmodules.github.io/busted/

MIT License

1.4k stars 185 forks source link

Link broken on busted 2.0.0 installation via Luarocks #602

Closed edubart closed 5 years ago

edubart commented 5 years ago

luarocks install --local busted
Installing https://luarocks.org/busted-2.0.0-0.rockspec

Error: Error fetching file: Failed downloading https://github.com/Olivine-Labs/busted/archive/v2.0.0-0.tar.gz - v2.0.0-0.tar.gz

The link is broken as shown above.

hugomg commented 5 years ago

Looks like the rockspec is pointing to 2.0.0-0.tar.gz but the actual file is at 2.0.0.tar.gz

rubensayshi commented 5 years ago

looks like somethint went wrong publishing v2.0.0, easy workaround is luarocks install busted 2.0.rc13-0

komapa commented 5 years ago

@ajacksified you gotta fix the release here in Github to have the trailing -0 as in v2.0.0-0 in order to fix this.

Tieske commented 5 years ago

the proper fix is to update the rockspec. Releases should not include the rockspec revision number (the trailing -0)

So remove the -0 suffixes from the rockspec contents, then rename the rockspec to -1 (the next revision), and publish it.

Pushing a new tag which includes the -0 to github will also work, but is the wrong solution.

rubensayshi commented 5 years ago

thx for fixing it quickly @Tieske @ajacksified !