lunarmodules / busted

Elegant Lua unit testing.
https://lunarmodules.github.io/busted/
MIT License
1.39k stars 184 forks source link

Isolate 3rd party libraries used internally by Busted from test environments #654

Open alerque opened 3 years ago

alerque commented 3 years ago

Fixes #643

Before anything else, this fixes what seems to be an unrelated bug in the loaded table state isolation. The current package loaded state table save/restore functions were only working in one direction. The packages in the current package.loaded are restored to the state they were in at the save point, but anything that was in the save point but is no longer in the current package list (i.e. in the event of unloading a package, switching to a different version of the same package, or switching to a different isolation environment) would be left in because the keys from the save point are not iterated, only the keys from the current state.

After that, this (currently) takes the approach described in my comment here, only isolating 3rd party libraries loaded by Busted for it's own use, not Busted itself.