search

lunarmodules / busted

Elegant Lua unit testing.
https://lunarmodules.github.io/busted/
MIT License
1.39k stars 184 forks source link

Change rockspec URL to git+https #677

Closed Frenzie closed 2 years ago

Frenzie commented 2 years ago

Resolves this error:

Cloning into 'busted'...
fatal: remote error:
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.

Cf. https://github.com/Olivine-Labs/busted/issues/668#issuecomment-1073215957.

Tieske commented 2 years ago

unfortunately all existing rockspecs must also be updated, and re-uploaded

alerque commented 2 years ago

Yes, this is unfortunate but true.

Just a note on working around this for anybody getting stuck: the latest LuaRocks release (3.8.0) has a workaround built in to automatically update URLs in any rockspecs it processes. This won't help older LuaRocks versions trying to install order versions of rocks, but if you have the option to update LuaRocks that's one way forward.

Frenzie commented 2 years ago

unfortunately all existing rockspecs must also be updated, and re-uploaded

Is this a request for some kind of change in this PR? As it is nothing works and presumably all of us would like master to Just Work™. ;-)

Tieske commented 2 years ago

@Frenzie A newer version of LuaRocks will automatically cover this case. So upgrading should get you unblocked.

@ajacksified The API key I have currently doesn't work, so I cannot fix this issue. If you can send me a new working one, I'll take care of this.

Frenzie commented 2 years ago

The latest rockspec plus old luarocks matters for convenience, the old rockspec not so much. :-)