search

lunarmodules / busted

Elegant Lua unit testing.
https://lunarmodules.github.io/busted/
MIT License
1.38k stars 184 forks source link

bad release #712

Closed Tieske closed 1 year ago

Tieske commented 1 year ago

I pushed a release today, and messed it up.

Had to push 3 rockspecs (because the SCM one depends is luarocks 3 format). But more seriously, I pushed it as a patch where it actually contains features and hence should have been v2.2.0 instead of v2.1.2.

So I'm wondering whether to push an addition 2.2 tag. Possibly even push a 2.1.3 without the changes.

wdyt @alerque ?

sorry about the mess 😞

alerque commented 1 year ago

Unless some platform has any trouble with the new features I'd be inclined to leave the mistake exactly how it is. Yes the semver is wrong, but backing out a feature from a patch release is just as likely to cause an issue for some platform out there as correcting the semver with two more tags and a revert commit. The patch tag is already on LuaRocks with a few hundred downloads, so lets just let it ride and see if any other factors come into play.