search

lunarmodules / busted

Elegant Lua unit testing.
https://lunarmodules.github.io/busted/
MIT License
1.38k stars 184 forks source link

fix(rockspec): remove luafilesystem, not a dependency #713

Closed dundargoc closed 1 year ago

dundargoc commented 1 year ago

"lfs" isn't being required in the codebase.

alerque commented 1 year ago

I think (but it is kind of disconcerting that CI runs did not show this) that lfs gets checked for in one of our dependencies where it is an optional dependency—and that we need the optional dependency required. On the other hand we also depend on Penlight, which in turn requires LuaFileSystem, so perhaps that's why CI didn't surface a problem. It ends up on the system anyway even if we do drop this here.

I'm happy to drop it if that is not the case, but it may not be quite as simple as grepping for lfs.

dundargoc commented 1 year ago

I've grepped for lfs not only in busted but in every package it includes transitively. It is only used in penlight.