Closed mpeterv closed 9 years ago
Please don't use "path ending with a slash" as a criteria. It leads to bad UX (I'm thinking here of all the times I had to look at rsync documentation (and still messed up!) because paths ending with and without slash have different semantics). In pathnames "/usr/lib/" and "/usr/lib" are supposed to mean the same, so it would be very unobvious looking at the configuration that the trailing slash is important.
Could you make it so that the presence of a wildcard in the key means that the value is a directory prefix (not requiring a trailing slash)?
Sure, that makes much more sense, pushed a fix. Should I squash it with the first commit?
Should I squash it with the first commit?
Don't worry about it :)
Thank you!!
Great, thanks! What do you think about adding rockspecs
option that would automatically import modules from a rockspec for even easier configuring?
Unfortunately that would only work with builtin-type recipes :\
Added new option for mapping module names to files where there are located. Modules are specified in the same way as in rockspecs, with a shortcut for many submodules:
instead of
Module names are converted to patterns and added to
included
list automatically. When reporting, "real" filenames (values in themodules
table) are used instead of original paths pointing to wherever luarocks installed them. So this addresses moteus/luacov-coveralls#2.