Replace roskspecs/ with a single scm rockspec

lunarmodules / luafilesystem

LuaFileSystem is a Lua library developed to complement the set of functions related to file systems offered by the standard Lua distribution.

https://lunarmodules.github.io/luafilesystem/

MIT License

907 stars 292 forks source link

Replace roskspecs/ with a single scm rockspec #108

Closed mpeterv closed 6 years ago

mpeterv commented 6 years ago

There is no need to keep rockspecs for older versions - it's enough to ensure that luarocks make builds currently checked out version.

luarocks new-version <rockspec> <version> --tag=<tag> generates rockspecs for releases.

Use scm instead of dev as LuaRocks 2 thinks that dev versions are less than normal versions like 1.6.3, making it tricky to use bleeding-edge version as a dependency with a constraint such as luafilesystem >= 1.6.3.

coveralls commented 6 years ago

Coverage remained the same at 80.144% when pulling ff193504aa6a60b02d25ff2664436379e2abb942 on mpeterv:remove-rockspecs into 37d8524e7e5237d3d67b2db4692b00b0eb95077b on keplerproject:master.

mpeterv commented 6 years ago

This is very optional but I think having a heap of rockspecks does make it a bit difficult to figure out what to update when there are changes in dependencies or source files. Always generating release rockspecs from scm rockspecs automatically also ensures there are no discrepancies between them. E.g. currently luafilesystem cvs-3 requires lua < 5.4 while the latest release (1.7.0-2) doesn't.