search

lunarmodules / luafilesystem

LuaFileSystem is a Lua library developed to complement the set of functions related to file systems offered by the standard Lua distribution.
https://lunarmodules.github.io/luafilesystem/
MIT License
907 stars 293 forks source link

Upload new dev-rockspec to LuaRocks.org #150

Closed siffiejoe closed 3 years ago

siffiejoe commented 3 years ago

The latest dev rockspec on LuaRocks.org is cvs-4 from 5 years ago. There is also a corresponding source rock for that version, so all dev installations use obsolete source code. This leads to build failures for Lua 5.4 since the old source code didn't support that Lua version (but the rockspec incorrectly claims "lua >= 5.1").

See this stackoverflow question.

hishamhm commented 3 years ago

dev rockspecs shouldn't include src.rock entries in the repo, that's the problem. The current dev rockspec itself should be fine, right?

On Fri, May 14, 2021, 03:01 Philipp Janda @.***> wrote:

The latest dev rockspec on LuaRocks.org is cvs-4 from 5 years ago. There is also a corresponding source rock for that version, so all dev installations use obsolete source code. This leads to build failures for Lua 5.4 since the old source code didn't support that Lua version (but the rockspec incorrectly claims "lua >= 5.1").

See this stackoverflow question https://stackoverflow.com/questions/67528613/cannot-install-penlight-unsupported-lua-version .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/keplerproject/luafilesystem/issues/150, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB365KEDSOTFFIG3635NILTNS4EJANCNFSM4432IQZA .

siffiejoe commented 3 years ago

The scm-1 rockspec in the repository works fine for Lua 5.1 - 5.4 on Linux.

hishamhm commented 3 years ago

I have deleted the src.rock file that was in the repo (oddly, it listed 0 downloads).

hishamhm commented 3 years ago

cvs-4 looks identical to scm-1, so I think this should be good to close. Feel free to reopen if there are still any problems. Thanks for bringing it up!