lunarmodules / luasocket

Network support for the Lua language

http://lunarmodules.github.io/luasocket/

MIT License

1.83k stars 626 forks source link

Field _VERSION not updated when v3.1.0 was released #401

Closed oktoberfest6 closed 10 months ago

oktoberfest6 commented 1 year ago

lua -e "print(require('socket')._VERSION)" --> LuaSocket 3.0.0

Seems that luasocket.h has not been updated:

define LUASOCKET_VERSION "LuaSocket 3.0.0"

edubart commented 1 year ago

I confirm this. HTTP agent for requests shows as LuaSocket 3.0.0, while I am using 3.1.0.

alerque commented 1 year ago

This will have to be fixed when v3.1.1 or similar is released. There is no sane way to fix in in an old release without creating an inconsistent situation where distros that have packaged this have different code than others. I'll leave this open to track that we need to hunt down where that string came from when we release.

alerque commented 10 months ago

This is fixed so at least the SCM rockspec will identify as the last stable tag. When we release next we still have to grep for all the places the string is hard coded. Eventually I'd like to fix the release process so that is automatic.

tpimh commented 3 months ago

Are there any plans for 3.1.1 release?